[PATCH i-g-t] tests/kms_big_fb: Test patch (not for merge)

Vidya Srinivas vidya.srinivas at intel.com
Wed Aug 4 13:24:41 UTC 2021


Trying to fix CRC issue with async flip on 5.4 kernel

Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
---
 tests/kms_big_fb.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index c6f374bdd073..43c7d755d946 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -549,7 +549,6 @@ max_hw_stride_async_flip_test(data_t *data)
 			} while (ret == -EBUSY);
 			igt_assert(ret == 0);
 		}
-
 		igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
 					   startframe, &compare_crc);
 		igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
@@ -564,6 +563,7 @@ max_hw_stride_async_flip_test(data_t *data)
 	}
 	igt_reset_timeout();
 
+	igt_pipe_crc_stop(data->pipe_crc);
 	igt_pipe_crc_free(data->pipe_crc);
 	igt_output_set_pipe(data->output, PIPE_NONE);
 	igt_remove_fb(data->drm_fd, &data->big_fb);
@@ -852,7 +852,6 @@ igt_main
 			data.render_copy = igt_get_render_copyfunc(data.devid);
 
 		data.bops = buf_ops_create(data.drm_fd);
-		data.ibb = intel_bb_create(data.drm_fd, 4096);
 
 		data.planeclearrgb[0] = 0.0;
 		data.planeclearrgb[1] = 0.0;
@@ -978,7 +977,9 @@ igt_main
 						igt_require(data.format == DRM_FORMAT_C8 ||
 							igt_fb_supported_format(data.format));
 						igt_require(igt_display_has_format_mod(&data.display, data.format, data.modifier));
+						data.ibb = intel_bb_create(data.drm_fd, 4096);
 						test_scanout(&data);
+						intel_bb_destroy(data.ibb);
 					}
 
 					// async flip doesn't support linear fbs.
@@ -993,8 +994,10 @@ igt_main
 								igt_fb_supported_format(data.format));
 							igt_require(igt_display_has_format_mod(&data.display, data.format, data.modifier));
 							igt_require_f(data.async_flip_support, "Async Flip is not supported\n");
-							data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
+							data.max_hw_fb_width = max(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
+							data.ibb = intel_bb_create(data.drm_fd, 4096);
 							test_scanout(&data);
+							intel_bb_destroy(data.ibb);
 					}
 					data.async_flip_test = false;
 				}
-- 
2.32.0



More information about the Intel-gfx-trybot mailing list