[PATCH 02/57] drm/i915/gt: Always flush the submission queue on checking for idle

[Tvrtko Ursulin]

On 05/02/2021 01:18, Chris Wilson wrote:
> We check for idle during debug prints and other debugging actions.
> Simplify the flow by not touching execlists state.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/intel_engine_cs.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index 9cd5cb2b1f1d..daadada6de0b 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -1247,14 +1247,8 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine)
>   		return true;
>   
>   	/* Waiting to drain ELSP? */
> -	if (execlists_active(&engine->execlists)) {
> -		synchronize_hardirq(to_pci_dev(engine->i915->drm.dev)->irq);
> -
> -		intel_engine_flush_submission(engine);
> -
> -		if (execlists_active(&engine->execlists))
> -			return false;
> -	}
> +	synchronize_hardirq(to_pci_dev(engine->i915->drm.dev)->irq);
> +	intel_engine_flush_submission(engine);
>   
>   	/* ELSP is empty, but there are ready requests? E.g. after reset */
>   	if (!RB_EMPTY_ROOT(&engine->execlists.queue.rb_root))
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko