[PATCH 5/5] Revert "drm/i915: Skip over MI_NOOP when parsing"

[Bloomfield, Jon]

> -----Original Message-----
> From: Jason Ekstrand <jason at jlekstrand.net>
> Sent: Thursday, May 27, 2021 3:13 PM
> To: intel-gfx-trybot at lists.freedesktop.org
> Cc: Jason Ekstrand <jason at jlekstrand.net>; Bloomfield, Jon
> <jon.bloomfield at intel.com>
> Subject: [PATCH 5/5] Revert "drm/i915: Skip over MI_NOOP when parsing"
> 
> This reverts a6c5e2aea704 ("drm/i915: Skip over MI_NOOP when parsing").
> It complicates the batch parsing code a bit and increases indentation
> for no reason other than fast-skipping a command that userspace uses
> only rarely.  Sure, there may be IGT tests that fill batches with NOOPs
> but that's not a case we should optimize for in the kernel.  We should
> optimize for code clarity instead.
> 
> Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> Cc: Jon Bloomfield <jon.bloomfield at intel.com>
> ---
Reviewed-by: Jon Bloomfield <jon.bloomfield at intel.com>