[PATCH 2/2] drm/i915: Add signaling semantics to dma_fence_work

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Thu Jun 3 10:03:51 UTC 2021


Since the worker has signaling semantics, it needa dma-fence signaling
annotations to pick up any future lockdep splats.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch> #irc
---
 drivers/gpu/drm/i915/i915_sw_fence_work.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_sw_fence_work.c b/drivers/gpu/drm/i915/i915_sw_fence_work.c
index a3a81bb8f2c3..8f6b84079b6e 100644
--- a/drivers/gpu/drm/i915/i915_sw_fence_work.c
+++ b/drivers/gpu/drm/i915/i915_sw_fence_work.c
@@ -17,12 +17,14 @@ static void fence_work(struct work_struct *work)
 {
 	struct dma_fence_work *f = container_of(work, typeof(*f), work);
 	int err;
+	bool cookie = dma_fence_begin_signalling();
 
 	err = f->ops->work(f);
 	if (err)
 		dma_fence_set_error(&f->dma, err);
 
 	fence_complete(f);
+	dma_fence_end_signalling(cookie);
 	dma_fence_put(&f->dma);
 }
 
-- 
2.31.0



More information about the Intel-gfx-trybot mailing list