[PATCH 0/3] Add multitile support

[Tvrtko Ursulin]

On 17/11/2021 00:42, Andi Shyti wrote:
> Hi guys,
> 
> just CC'ing you in the trybot patch series to have a first check
> amongst us.
> 
> Biggest changes are that I renamed i915->gt to i915->gt0, so that
> we can have i915->gt[], which is going to have huge
> repercussions.

i915->gt0 sounds very nice with churn being the main drawback I can 
think of. Just the fact you have to go and change all the legacy parts 
of the driver which have no concept of more than one GT. During initial 
bringup design goal was explicitly to avoid that.

Secondly, if the main motivation is dislike of plural variable names 
then I personally don't share that concern. It is just something to get 
used to.

Hopefully the main idea is that i915->gt0 becomes harder to misuse? I 
think we did talk about renaming to i915->__gt__ or something back then, 
which would be similarly off putting. Possibly the churn was the reason 
we did not go for it.

Either way I am okay with gt0 if consensus is made.

Regards,

Tvrtko

> 
> I have squashed patch 3, 5, 10... I see them together in one
> single as to me it doesn't make sense to post pre-pre-patch, then
> a pre-patch and then the patch.
> 
> I will reply inline to some for some doubts I still have.
> 
> Other than that, I got Abdiel's private contacts so that we can
> still name him fully in the series.
> 
> Thanks,
> Andi
> 
> Andi Shyti (1):
>    drm/i915: Rename gt to gt0
> 
> Michał Winiarski (1):
>    drm/i915: Store backpointer to GT in uncore
> 
> Tvrtko Ursulin (1):
>    drm/i915: prepare for multiple gt platforms
> 
>   .../gpu/drm/i915/display/intel_atomic_plane.c |   4 +-
>   drivers/gpu/drm/i915/display/intel_display.c  |  18 +-
>   drivers/gpu/drm/i915/display/intel_dpt.c      |   2 +-
>   drivers/gpu/drm/i915/display/intel_overlay.c  |   2 +-
>   .../drm/i915/display/skl_universal_plane.c    |   2 +-
>   drivers/gpu/drm/i915/gem/i915_gem_context.c   |  22 +--
>   drivers/gpu/drm/i915/gem/i915_gem_create.c    |   2 +-
>   .../gpu/drm/i915/gem/i915_gem_execbuffer.c    |   2 +-
>   drivers/gpu/drm/i915/gem/i915_gem_mman.c      |   2 +-
>   drivers/gpu/drm/i915/gem/i915_gem_phys.c      |   4 +-
>   drivers/gpu/drm/i915/gem/i915_gem_pm.c        |   6 +-
>   drivers/gpu/drm/i915/gem/i915_gem_shrinker.c  |   2 +-
>   drivers/gpu/drm/i915/gem/i915_gem_throttle.c  |   2 +-
>   drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c  |  12 +-
>   drivers/gpu/drm/i915/gem/i915_gem_userptr.c   |   2 +-
>   drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   2 +-
>   drivers/gpu/drm/i915/gt/intel_engine_user.c   |   2 +-
>   drivers/gpu/drm/i915/gt/intel_ggtt.c          |   2 +-
>   drivers/gpu/drm/i915/gt/intel_gt.c            | 186 +++++++++++++++++-
>   drivers/gpu/drm/i915/gt/intel_gt.h            |   9 +
>   drivers/gpu/drm/i915/gt/intel_gt_pm.c         |   9 +-
>   drivers/gpu/drm/i915/gt/intel_gt_types.h      |  10 +
>   drivers/gpu/drm/i915/gt/intel_rps.c           |  12 +-
>   drivers/gpu/drm/i915/gt/intel_workarounds.c   |   2 +-
>   drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   |   2 +-
>   drivers/gpu/drm/i915/gvt/gvt.c                |   2 +-
>   drivers/gpu/drm/i915/gvt/scheduler.c          |   2 +-
>   drivers/gpu/drm/i915/i915_debugfs.c           |  38 ++--
>   drivers/gpu/drm/i915/i915_debugfs_params.c    |   4 +-
>   drivers/gpu/drm/i915/i915_drv.c               |  74 ++++---
>   drivers/gpu/drm/i915/i915_drv.h               |  11 +-
>   drivers/gpu/drm/i915/i915_gem.c               |  16 +-
>   drivers/gpu/drm/i915/i915_getparam.c          |  10 +-
>   drivers/gpu/drm/i915/i915_gpu_error.c         |   4 +-
>   drivers/gpu/drm/i915/i915_irq.c               |  56 +++---
>   drivers/gpu/drm/i915/i915_perf.c              |   2 +-
>   drivers/gpu/drm/i915/i915_pmu.c               |  14 +-
>   drivers/gpu/drm/i915/i915_query.c             |   2 +-
>   drivers/gpu/drm/i915/i915_reg.h               |   4 +
>   drivers/gpu/drm/i915/i915_sysfs.c             |  22 +--
>   drivers/gpu/drm/i915/intel_device_info.h      |  15 ++
>   drivers/gpu/drm/i915/intel_gvt.c              |   2 +-
>   drivers/gpu/drm/i915/intel_memory_region.h    |   3 +
>   drivers/gpu/drm/i915/intel_uncore.c           |  21 +-
>   drivers/gpu/drm/i915/intel_uncore.h           |   6 +-
>   drivers/gpu/drm/i915/intel_wopcm.c            |   2 +-
>   .../gpu/drm/i915/selftests/mock_gem_device.c  |   3 +-
>   drivers/gpu/drm/i915/selftests/mock_uncore.c  |   2 +-
>   48 files changed, 444 insertions(+), 191 deletions(-)
>