[PATCH i-g-t 4/5] tests/gem_exec_fence: Restore post-hang checks on exclists configs

Janusz Krzysztofik janusz.krzysztofik at linux.intel.com
Thu Aug 4 17:14:46 UTC 2022


Commit c8f6aaf32d83 "tests/gem_exec_fence: Check stored values only for
valid workloads" resolved an issue, observed in *await-hang scenarios,
where test batches waiting on a fence exposed by an invalid spin batch
were not executed, despite the fence being signaled, due to potential
reset of those test batches, by disabling those checks, then weakening
those scenarios.  This change re-enables the checks on execlists
submission configurations, where we never expect that reset to happen.

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
---
 tests/i915/gem_exec_fence.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index 27af9718d9..dff0ca32da 100644
--- a/tests/i915/gem_exec_fence.c
+++ b/tests/i915/gem_exec_fence.c
@@ -383,7 +383,11 @@ static void test_fence_await(int fd, const intel_ctx_t *ctx,
 
 	gem_set_domain(fd, scratch, I915_GEM_DOMAIN_GTT, 0);
 	igt_assert(!fence_busy(out_fence));
-	if ((flags & HANG) == 0) {
+	/*
+	 * FIXME: find out when exactly we may expect out[i] == i, when out[i] == 0,
+	 *	  if using GuC submission
+	 */
+	if ((flags & HANG) == 0 || !gem_using_guc_submission(fd)) {
 		do
 			igt_assert_eq_u32(out[i], i);
 		while (--i);
-- 
2.25.1



More information about the Intel-gfx-trybot mailing list