[PATCH] drm/i915/backlight: Disable pps power hook for aux based backlight

Jouni Högander jouni.hogander at intel.com
Mon Aug 22 10:37:00 UTC 2022


Pps power hook seems to be problematic for backlight controlled via
aux channel. Disable it for such cases.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
---
 drivers/gpu/drm/i915/display/intel_backlight.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index af28b143d27a..c218a1954e8c 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -1779,8 +1779,14 @@ void intel_backlight_init_funcs(struct intel_panel *panel)
 	}
 
 	if (connector->base.connector_type == DRM_MODE_CONNECTOR_eDP &&
-	    intel_dp_aux_init_backlight_funcs(connector) == 0)
+	    intel_dp_aux_init_backlight_funcs(connector) == 0) {
+		/*
+		 * PPS backlight power hook seems to be problematic
+		 * for aux based backlight control -> disable it.
+		 */
+		dev_priv->quirks |= QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK;
 		return;
+	}
 
 	/* We're using a standard PWM backlight interface */
 	panel->backlight.funcs = &pwm_bl_funcs;
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list