[PATCH v3 0/7] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

Alan Previn alan.previn.teres.alexis at intel.com
Wed Dec 21 02:10:28 UTC 2022


A customer issue was recently discovered and in the process a
gap in i915's PXP interaction with HW+FW architecure was also
realized. This series adds those missing pieces.

This series includes changes where i915 calls into the mei
component interface in order to submit requests to the security
firmware during the i915's suspend_prepare flow. This change did
expose a blocking issue that was discovered in rev1. Thus,
we have now included the mei patches as well that adds device-
link based on the interface type to enforce mei side runtime
resume during the i915's suspend_prepare call.

The individual patches explain the details.

Changes from prior revs:
   v1: - Dont need to teardown non arbitration sessions (Juston).
       - Fix builds when PXP is enabled in config (Alan/CI-build)
       - Fix the broken pm-suspend-resume symmetry when we do this
         pxp-session-teardown during i915s pm_suspend_prepare by
         ensuring the init is done during i915s pm_resume_complete.
   v2: - Rebase on latest drm-tip after PXP subsytem was promoted
         to global
       - Remove "INTEL_PXP_MAX_HWDRM_SESSIONS" unneeded (Juston Li)
       - Added mei patches that are dependencies for this series
         to successfully pass testing when PXP config is enabled.

Alan Previn (3):
  drm/i915/pxp: Invalidate all PXP fw sessions during teardown
  drm/i915/pxp: Trigger the global teardown for before suspending
  drm/i915/pxp: Pxp hw init should be in resume_complete
  HAX: force enable PXP Kconfig

Alexander Usyskin (3):
  mei: mei-me: resume device in prepare
  drm/i915/pxp: add device link between i915 and mei_pxp
  mei: clean pending read with vtag on bus

 drivers/gpu/drm/i915/Kconfig                  |  2 +-
 drivers/gpu/drm/i915/gt/intel_gt_pm.h         |  1 +
 drivers/gpu/drm/i915/i915_driver.c            | 20 ++++++-
 drivers/gpu/drm/i915/pxp/intel_pxp.c          | 60 ++++++++++++++++---
 drivers/gpu/drm/i915/pxp/intel_pxp.h          |  2 +
 .../drm/i915/pxp/intel_pxp_cmd_interface_42.h | 15 +++++
 .../i915/pxp/intel_pxp_cmd_interface_cmn.h    |  3 +
 drivers/gpu/drm/i915/pxp/intel_pxp_pm.c       |  4 +-
 drivers/gpu/drm/i915/pxp/intel_pxp_pm.h       |  6 +-
 drivers/gpu/drm/i915/pxp/intel_pxp_session.c  | 11 +++-
 drivers/gpu/drm/i915/pxp/intel_pxp_session.h  |  5 ++
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c      | 42 +++++++++++++
 drivers/misc/mei/client.c                     |  4 +-
 drivers/misc/mei/pci-me.c                     | 13 ++++
 drivers/misc/mei/pxp/Kconfig                  |  1 +
 15 files changed, 168 insertions(+), 21 deletions(-)


base-commit: cc44a1e87ea6b788868878295119398966f98a81
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list