[PATCH 08/27] drm/i915/guc: Disable HuC authentication on newer DG2

Ramalingam C ramalingam.c at intel.com
Tue Feb 8 14:14:26 UTC 2022


From: John Harrison <John.C.Harrison at Intel.com>

Newer DG2 platforms have GuC deprivilidge enabled. That means that the
GuC can no longer authenticate the HuC. An alternative mechanism must
be used involving the MEI device. Unfortunately, the driver/firmware
support for that is still a work in progress.

So for time being, disable HuC on these platforms to prevent the error
messages about failed authentication causing CI failures.

Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
Signed-off-by: Ramalingam C <ramalingam.c at intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_uc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index 3e9716138a0d..b24f88a929a7 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
@@ -43,6 +43,10 @@ static void uc_expand_default_options(struct intel_uc *uc)
 
 	/* Default: enable HuC authentication and GuC submission */
 	i915->params.enable_guc = ENABLE_GUC_LOAD_HUC | ENABLE_GUC_SUBMISSION;
+
+	/* FIXME: DG2 with depriv can't authenticate HuC until MEI driver is updated */
+	if (IS_DG2(i915) && !IS_DG2_GRAPHICS_STEP(i915, G10, STEP_A0, STEP_A1))
+		i915->params.enable_guc &= ~ENABLE_GUC_LOAD_HUC;
 }
 
 /* Reset GuC providing us with fresh state for both GuC and HuC.
-- 
2.20.1



More information about the Intel-gfx-trybot mailing list