[i-g-t 04/16] tests/kms_color: New subtests for Plane gamma
Bhanuprakash Modem
bhanuprakash.modem at intel.com
Wed Jul 20 10:48:30 UTC 2022
To verify Plane gamma, draw 3 gradient rectangles in red, green and blue,
with a maxed out gamma LUT and verify we have the same CRC as drawing solid
color rectangles.
v2:
* Drop Intel specific logic (Pekka)
* Add a support for extended mode (Bhanu)
v3:
* Add support to validate 'no gamma' mode (Harry)
v4:
* Rebase
* Dynamic subtests
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Pekka Paalanen <ppaalanen at gmail.com>
Cc: Uma Shankar <uma.shankar at intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
---
tests/kms_color.c | 187 +++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 185 insertions(+), 2 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index c202547e..1c868ffb 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -24,7 +24,9 @@
#include "kms_color_helper.h"
-IGT_TEST_DESCRIPTION("Test Color Features at Pipe level");
+IGT_TEST_DESCRIPTION("Test Color Features at Pipe & Plane level");
+
+static bool extended = false;
static bool test_pipe_degamma(data_t *data,
igt_plane_t *primary)
@@ -660,6 +662,119 @@ static void test_pipe_limited_range_ctm(data_t *data,
}
#endif
+static bool plane_gamma_test(data_t *data, igt_plane_t *plane)
+{
+ igt_output_t *output = data->output;
+ igt_display_t *display = &data->display;
+ drmModeModeInfo *mode = data->mode;
+ struct igt_fb fb;
+ drmModePropertyPtr gamma_mode = NULL;
+ uint32_t i;
+ bool ret = true;
+ igt_pipe_crc_t *pipe_crc = data->pipe_crc;
+ color_t red_green_blue[] = {
+ { 1.0, 0.0, 0.0 },
+ { 0.0, 1.0, 0.0 },
+ { 0.0, 0.0, 1.0 }
+ };
+
+ igt_info("Plane gamma test is running on pipe-%s plane-%d(%s)\n",
+ kmstest_pipe_name(plane->pipe->pipe), plane->index,
+ kmstest_plane_type_name(plane->type));
+
+ igt_require(igt_plane_has_prop(plane, IGT_PLANE_GAMMA_MODE));
+ igt_require(igt_plane_has_prop(plane, IGT_PLANE_GAMMA_LUT));
+
+ igt_output_set_pipe(output, plane->pipe->pipe);
+
+ /* Create a framebuffer at the size of the output. */
+ igt_assert(igt_create_fb(data->drm_fd,
+ mode->hdisplay,
+ mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ &fb));
+ igt_plane_set_fb(plane, &fb);
+
+ /* Disable Pipe color props. */
+ disable_ctm(plane->pipe);
+ disable_degamma(plane->pipe);
+ disable_gamma(plane->pipe);
+
+ disable_plane_ctm(plane);
+ disable_plane_degamma(plane);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+
+ gamma_mode = get_plane_gamma_degamma_mode(plane, IGT_PLANE_GAMMA_MODE);
+
+ /* Iterate all supported gamma modes. */
+ for (i = 0; i < gamma_mode->count_enums; i++) {
+ igt_crc_t crc_gamma, crc_fullcolors;
+ segment_data_t *segment_info = NULL;
+ struct drm_color_lut_ext *lut = NULL;
+ uint32_t lut_size = 0;
+
+ igt_info("Trying to use gamma mode: \'%s\'\n", gamma_mode->enums[i].name);
+
+ /* Draw solid colors with no gamma transformation. */
+ disable_plane_gamma(plane);
+ paint_rectangles(data, mode, red_green_blue, &fb);
+ igt_plane_set_fb(plane, &fb);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[plane->pipe->pipe].crtc_offset);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_fullcolors);
+
+ /* 'no gamma' is intended to disable the gamma.
+ * Hence, setting GAMMA_LUT to NULL (i.e disable_plane_gamma())
+ * and setting GAMMA_MODE as 'no gamma' (i.e set_plane_gamma())
+ * should produce the same result.
+ */
+ if (strcmp(gamma_mode->enums[i].name, "no gamma")) {
+ segment_info = get_segment_data(data,
+ gamma_mode->enums[i].value,
+ gamma_mode->enums[i].name);
+ lut_size = sizeof(struct drm_color_lut_ext) * segment_info->entries_count;
+ lut = create_max_lut(segment_info);
+ if (is_i915_device(data->drm_fd))
+ lut[0].red = lut[0].green = lut[0].blue = 0; /* First entry is 0 for Intel h/w. */
+
+ /* Draw gradient colors with gamma LUT to remap all
+ * values to max red/green/blue.
+ */
+ paint_gradient_rectangles(data, mode, red_green_blue, &fb);
+ igt_plane_set_fb(plane, &fb);
+ }
+
+ set_plane_gamma(plane, gamma_mode->enums[i].name, lut, lut_size);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[plane->pipe->pipe].crtc_offset);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_gamma);
+
+ /* Verify that the CRC of the software computed output is
+ * equal to the CRC of the gamma LUT transformation output.
+ */
+ ret &= igt_check_crc_equal(&crc_gamma, &crc_fullcolors);
+
+ free(lut);
+ clear_segment_data(segment_info);
+ }
+
+ disable_plane_gamma(plane);
+ igt_plane_set_fb(plane, NULL);
+ igt_output_set_pipe(output, PIPE_NONE);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+
+ drmModeFreeProperty(gamma_mode);
+
+ return ret;
+}
+
static void
prep_pipe(data_t *data, enum pipe p)
{
@@ -728,6 +843,40 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p,
test_cleanup(data);
}
+static void run_plane_color_test(data_t *data, enum pipe pipe,
+ bool (*test_t)(data_t*, igt_plane_t*))
+{
+ igt_plane_t *plane;
+ int count = 0;
+ int last_plane = (&data->display)->pipes[pipe].n_planes - 1;
+
+ for_each_plane_on_pipe(&data->display, pipe, plane) {
+ if (!extended && j__ != 0 && j__ != last_plane)
+ continue;
+
+ igt_assert(test_t(data, plane));
+
+ count++;
+ }
+
+ igt_require_f(count, "No valid planes found.\n");
+}
+
+static void
+run_gamma_degamma_tests_for_plane(data_t *data, enum pipe p,
+ bool (*test_t)(data_t*, igt_plane_t*))
+{
+ test_setup(data, p);
+
+ data->drm_format = DRM_FORMAT_XRGB8888;
+ data->mode = igt_output_get_mode(data->output);
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
+ run_plane_color_test(data, p, test_t);
+
+ test_cleanup(data);
+}
+
static void
run_ctm_tests_for_pipe(data_t *data, enum pipe p,
color_t *expected_colors,
@@ -1002,6 +1151,14 @@ run_tests_for_pipe(data_t *data)
"Check the color transformation for 0.75 transparency"
},
};
+ struct {
+ const char *name;
+ bool (*test_t)(data_t*, igt_plane_t*);
+ const char *desc;
+ } plane_gamma_degamma_tests[] = {
+ { "plane-gamma", plane_gamma_test,
+ "Compare maxed out plane gamma LUT and solid color linear LUT" },
+ };
int i;
for (i = 0; i < ARRAY_SIZE(gamma_degamma_tests); i++) {
@@ -1026,6 +1183,16 @@ run_tests_for_pipe(data_t *data)
}
}
+ for (i = 0; i < ARRAY_SIZE(plane_gamma_degamma_tests); i++) {
+ igt_describe_f("%s", plane_gamma_degamma_tests[i].desc);
+ igt_subtest_with_dynamic_f("%s", plane_gamma_degamma_tests[i].name) {
+ for_each_pipe(&data->display, pipe) {
+ run_gamma_degamma_tests_for_plane(data, pipe,
+ plane_gamma_degamma_tests[i].test_t);
+ }
+ }
+ }
+
igt_fixture
igt_require(data->display.is_atomic);
@@ -1037,7 +1204,23 @@ run_tests_for_pipe(data_t *data)
}
}
-igt_main
+static int opt_handler(int opt, int opt_index, void *data)
+{
+ switch (opt) {
+ case 'e':
+ extended = true;
+ break;
+ default:
+ return IGT_OPT_HANDLER_ERROR;
+ }
+
+ return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+ " -e \tExtended plane tests.\n";
+
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
{
data_t data = {};
--
2.35.1
More information about the Intel-gfx-trybot
mailing list