[PATCH 2/3] drm/i915/gem: dont't trample over cache_dirty setting
Adrian Larumbe
adrian.larumbe at collabora.com
Fri Jun 10 18:45:17 UTC 2022
i915_gem_object_set_cache_coherency is already setting the right
cache_coherency level and cache_dirty property, so the calling
function should never overwrite it.
Signed-off-by: Adrian Larumbe <adrian.larumbe at collabora.com>
---
drivers/gpu/drm/i915/gem/i915_gem_domain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
index 3e5d6057b3ef..b2c9e16bfa55 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
@@ -273,10 +273,8 @@ int i915_gem_object_set_cache_level(struct drm_i915_gem_object *obj,
return ret;
/* Always invalidate stale cachelines */
- if (obj->cache_level != cache_level) {
+ if (obj->cache_level != cache_level)
i915_gem_object_set_cache_coherency(obj, cache_level);
- obj->cache_dirty = true;
- }
/* The cache-level will be applied when each vma is rebound. */
return i915_gem_object_unbind(obj,
--
2.36.1
More information about the Intel-gfx-trybot
mailing list