[PATCH 4/4] debug
José Roberto de Souza
jose.souza at intel.com
Thu Mar 31 17:17:11 UTC 2022
Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
---
drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 808c6500ac1b1..7c2f94552c081 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -493,14 +493,6 @@ void intel_pipe_update_start(struct intel_crtc_state *new_crtc_state)
if (intel_crtc_needs_vblank_work(new_crtc_state))
intel_crtc_vblank_work_init(new_crtc_state);
- intel_psr_lock(new_crtc_state);
- /*
- * Wait for psr to idle out after enabling the VBL interrupts
- * VBL interrupts will start the PSR exit and prevent a PSR
- * re-entry as well.
- */
- intel_psr_wait_for_idle_locked(new_crtc_state);
-
if (new_crtc_state->vrr.enable) {
if (intel_vrr_is_push_sent(new_crtc_state))
vblank_start = intel_vrr_vmin_vblank_start(new_crtc_state);
@@ -515,11 +507,23 @@ void intel_pipe_update_start(struct intel_crtc_state *new_crtc_state)
VBLANK_EVASION_TIME_US);
max = vblank_start - 1;
- if (min <= 0 || max <= 0)
+ intel_psr_lock(new_crtc_state);
+ /*
+ * Wait for psr to idle out after enabling the VBL interrupts
+ * VBL interrupts will start the PSR exit and prevent a PSR
+ * re-entry as well.
+ */
+ intel_psr_wait_for_idle_locked(new_crtc_state);
+
+ if (min <= 0 || max <= 0) {
+ drm_info(&dev_priv->drm, "min(%i) <= 0 || max(%i) <= 0 | zeh\n", min, max);
goto irq_disable;
+ }
- if (drm_WARN_ON(&dev_priv->drm, drm_crtc_vblank_get(&crtc->base)))
+ if (drm_WARN_ON(&dev_priv->drm, drm_crtc_vblank_get(&crtc->base))) {
+ drm_info(&dev_priv->drm, "!drm_crtc_vblank_get | zeh\n");
goto irq_disable;
+ }
local_irq_disable();
--
2.35.1
More information about the Intel-gfx-trybot
mailing list