[PATCH i-g-t 1/1] tests/i915/i915_suspend: Disable d3cold_allowed for basic-s2idle-without-i915

Riana Tauro riana.tauro at intel.com
Tue Sep 13 17:26:45 UTC 2022


When module is unloaded and s2idle is triggered,
PCI core leaves the endpoint in D0 and the bridge in D3 state causing
PCIE spec violation. The config space is read as 0xFF

Keep the bridge in D0 before module unload to prevent
this issue

Signed-off-by: Riana Tauro <riana.tauro at intel.com>
---
 tests/i915/i915_suspend.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c
index 815f1c8a..8bf290e6 100644
--- a/tests/i915/i915_suspend.c
+++ b/tests/i915/i915_suspend.c
@@ -225,6 +225,8 @@ test_suspend_without_i915(int state)
 		igt_pm_get_d3cold_allowed(&card, d3cold_allowed);
 		igt_pm_set_d3cold_allowed(&card, "0\n");
 	}
+
+	igt_devices_free();
 	close(fd);
 
 	igt_kmsg(KMSG_INFO "Unloading i915\n");
@@ -238,7 +240,6 @@ test_suspend_without_i915(int state)
 	igt_kmsg(KMSG_INFO "Re-loading i915 \n");
 	igt_assert_eq(igt_i915_driver_load(NULL), 0);
 
-	igt_devices_free();
 }
 
 int fd;
-- 
2.25.1



More information about the Intel-gfx-trybot mailing list