[PATCH] drm/i915/dp: Drop the check for max bpp for eDP in case of DSC

Ankit Nautiyal ankit.k.nautiyal at intel.com
Tue Aug 22 03:30:51 UTC 2023


For eDP panels sometimes the color depth from EDID does not
match with decoder color depth capability in DPCD 6Ah.
Ignore the limits->max_bpp limitation due to EDID for eDP case.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5b48bfe09d0e..fe99e0fe23c2 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2061,10 +2061,19 @@ static int intel_edp_dsc_compute_pipe_bpp(struct intel_dp *intel_dp,
 	if (forced_bpp) {
 		pipe_bpp = forced_bpp;
 	} else {
+		int dsc_min_bpp;
+
 		/* For eDP use max bpp that can be supported with DSC. */
 		pipe_bpp = intel_dp_dsc_compute_max_bpp(intel_dp,
 							conn_state->max_requested_bpc);
-		if (!is_dsc_pipe_bpp_sufficient(i915, conn_state, limits, pipe_bpp)) {
+		/*
+		 * For eDP panels the sometimes the color depth from EDID does
+		 * not match with decoder color depth capability in DPCD 6Ah.
+		 * Ignore the limits->max_bpp due to EDID for eDP case, and
+		 * only ensure that pipe_bpp is more than the min possible bpp.
+		 */
+		dsc_min_bpp = max(intel_dp_dsc_min_src_input_bpc(i915) * 3, limits->min_bpp);
+		if (pipe_bpp < dsc_min_bpp) {
 			drm_dbg_kms(&i915->drm,
 				    "Computed BPC is not in DSC BPC limits\n");
 			return -EINVAL;
-- 
2.40.1



More information about the Intel-gfx-trybot mailing list