[PATCH 9/9] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs
Kandpal, Suraj
suraj.kandpal at intel.com
Sat Aug 26 18:26:36 UTC 2023
> Subject: [PATCH 9/9] drm/i915/dsc: Allow DSC only with fractional bpp when
> forced from debugfs
>
> From: Swati Sharma <swati2.sharma at intel.com>
>
> If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff
Typo at *if
> compressed bpp is fractional. Continue if we computed compressed bpp is
> computed as integer.
I think you wrote computed a little too many times here 😝
Regards,
Suraj Kandpal
>
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 011bcfe2ecc5..9098febf0c07 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1905,6 +1905,9 @@ xelpd_dsc_compute_link_config(struct intel_dp
> *intel_dp,
> for (compressed_bppx16 = dsc_max_bpp;
> compressed_bppx16 >= dsc_min_bpp;
> compressed_bppx16 -= bppx16_step) {
> + if (intel_dp->force_dsc_fractional_bpp_en &&
> + !dsc_fractional_compressed_bpp(compressed_bppx16))
> + continue;
> ret = dsc_compute_link_config(intel_dp,
> pipe_config,
> limits,
> @@ -1912,6 +1915,11 @@ xelpd_dsc_compute_link_config(struct intel_dp
> *intel_dp,
> timeslots);
> if (ret == 0) {
> pipe_config->dsc.compressed_bpp =
> compressed_bppx16;
> +
> + if (intel_dp->force_dsc_fractional_bpp_en &&
> +
> dsc_fractional_compressed_bpp(compressed_bppx16))
> + drm_dbg_kms(&i915->drm, "Forcing DSC
> fractional bpp\n");
> +
> return 0;
> }
> }
> --
> 2.40.1
More information about the Intel-gfx-trybot
mailing list