[PATCH] drm/i915/gt: Improve log in reset prepare

Nirmoy Das nirmoy.das at intel.com
Fri Dec 1 13:16:47 UTC 2023


Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
---
 drivers/gpu/drm/i915/gt/intel_reset.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index d5ed904f355d..64a69ba6bd79 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -593,10 +593,10 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine)
 	ret = __intel_wait_for_register_fw(uncore, reg, mask, ack,
 					   700, 0, NULL);
 	if (ret)
-		gt_err(engine->gt,
-		       "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n",
-		       engine->name, request,
-		       intel_uncore_read_fw(uncore, reg));
+		GT_TRACE(engine->gt,
+			 "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n",
+			 engine->name, request,
+			 intel_uncore_read_fw(uncore, reg));
 
 	return ret;
 }
@@ -622,8 +622,11 @@ static int gen8_reset_engines(struct intel_gt *gt,
 
 	for_each_engine_masked(engine, gt, engine_mask, tmp) {
 		ret = gen8_engine_reset_prepare(engine);
-		if (ret && !reset_non_ready)
+		if (ret && !reset_non_ready) {
+			gt_err(gt, "%s gen8_engine_reset_prepare timed out\n",
+			       engine->name);
 			goto skip_reset;
+		}
 
 		/*
 		 * If this is not the first failed attempt to prepare,
-- 
2.42.0



More information about the Intel-gfx-trybot mailing list