[PATCH] drm/i915/display: Remove wait for flip done on async flips

Arun R Murthy arun.r.murthy at intel.com
Fri Jul 14 05:22:56 UTC 2023


Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 44 --------------------
 1 file changed, 44 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 43cba98f7753..1e528d6561eb 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -965,40 +965,6 @@ static void intel_post_plane_update(struct intel_atomic_state *state,
 		intel_color_post_update(new_crtc_state);
 }
 
-static void intel_crtc_enable_flip_done(struct intel_atomic_state *state,
-					struct intel_crtc *crtc)
-{
-	const struct intel_crtc_state *crtc_state =
-		intel_atomic_get_new_crtc_state(state, crtc);
-	u8 update_planes = crtc_state->update_planes;
-	const struct intel_plane_state __maybe_unused *plane_state;
-	struct intel_plane *plane;
-	int i;
-
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
-		if (plane->pipe == crtc->pipe &&
-		    update_planes & BIT(plane->id))
-			plane->enable_flip_done(plane);
-	}
-}
-
-static void intel_crtc_disable_flip_done(struct intel_atomic_state *state,
-					 struct intel_crtc *crtc)
-{
-	const struct intel_crtc_state *crtc_state =
-		intel_atomic_get_new_crtc_state(state, crtc);
-	u8 update_planes = crtc_state->update_planes;
-	const struct intel_plane_state __maybe_unused *plane_state;
-	struct intel_plane *plane;
-	int i;
-
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
-		if (plane->pipe == crtc->pipe &&
-		    update_planes & BIT(plane->id))
-			plane->disable_flip_done(plane);
-	}
-}
-
 static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
 					     struct intel_crtc *crtc)
 {
@@ -7044,11 +7010,6 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 	intel_dbuf_pre_plane_update(state);
 	intel_mbus_dbox_update(state);
 
-	for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
-		if (new_crtc_state->do_async_flip)
-			intel_crtc_enable_flip_done(state, crtc);
-	}
-
 	/* Now enable the clocks, plane, pipe, and connectors that we set up. */
 	dev_priv->display.funcs.display->commit_modeset_enables(state);
 
@@ -7068,11 +7029,6 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 	 */
 	drm_atomic_helper_wait_for_flip_done(dev, &state->base);
 
-	for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
-		if (new_crtc_state->do_async_flip)
-			intel_crtc_disable_flip_done(state, crtc);
-	}
-
 	/*
 	 * Now that the vblank has passed, we can go ahead and program the
 	 * optimal watermarks on platforms that need two-step watermark
-- 
2.25.1



More information about the Intel-gfx-trybot mailing list