[PATCH 1/6] drm/i915: Move might_sleep() outside the loop

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Tue Jun 27 12:20:33 UTC 2023


From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

It is better to have debugging aids on the top level.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_object.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index 97ac6fb37958..318efcc6e884 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -402,8 +402,9 @@ static void __i915_gem_free_objects(struct drm_i915_private *i915,
 {
 	struct drm_i915_gem_object *obj, *on;
 
+	might_sleep();
+
 	llist_for_each_entry_safe(obj, on, freed, freed) {
-		might_sleep();
 		if (obj->ops->delayed_free) {
 			obj->ops->delayed_free(obj);
 			continue;
-- 
2.39.2



More information about the Intel-gfx-trybot mailing list