[RFC PATCH 06/22] drm/i915/psr: Use full frame updates for legacy cursor updates

Jouni Högander jouni.hogander at intel.com
Fri Mar 24 11:24:49 UTC 2023


Legacy Cursor update are not synced with vblank. This means there are
several cursor updates over one vblank and PSR code doesn't really
know which one of those updates got applied and sent to panel as
selective update. This means we If we want to have working selective
update for cursor update as well we need to implement cumulative SU
region for legacy cursor update.

Use full frame update for legacy cursor updates.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 0bd958b974f3..42122536f2a8 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1750,7 +1750,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 	if (!crtc_state->enable_psr2_sel_fetch)
 		return 0;
 
-	if (!psr2_sel_fetch_pipe_state_supported(crtc_state)) {
+	if (!psr2_sel_fetch_pipe_state_supported(crtc_state) ||
+	    state->base.legacy_cursor_update) {
 		full_update = true;
 		goto skip_sel_fetch_set_loop;
 	}
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list