[RFC PATCH 10/22] drm/i915/display: Remove unused frontbuffer references from intel_overlay

Jouni Högander jouni.hogander at intel.com
Fri Mar 24 11:24:53 UTC 2023


Overlay is currently calling many frontbuffer tracking interfaces.
We are following new strategy to rely purely on dirtyfb
callback. Remove all other references to frontbuffer tracking code
from intel_overlay.

Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
---
 drivers/gpu/drm/i915/display/intel_overlay.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 5b86563ce577..6d12d991cea7 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -285,13 +285,8 @@ static int intel_overlay_on(struct intel_overlay *overlay)
 static void intel_overlay_flip_prepare(struct intel_overlay *overlay,
 				       struct i915_vma *vma)
 {
-	enum pipe pipe = overlay->crtc->pipe;
-
 	drm_WARN_ON(&overlay->i915->drm, overlay->old_vma);
 
-	intel_frontbuffer_flip_prepare(overlay->i915,
-				       INTEL_FRONTBUFFER_OVERLAY(pipe));
-
 	overlay->old_vma = overlay->vma;
 	if (vma)
 		overlay->vma = i915_vma_get(vma);
@@ -341,14 +336,15 @@ static int intel_overlay_continue(struct intel_overlay *overlay,
 
 static void intel_overlay_release_old_vma(struct intel_overlay *overlay)
 {
+	struct drm_i915_private *i915 = overlay->i915;
+	enum pipe pipe = overlay->crtc->pipe;
 	struct i915_vma *vma;
 
 	vma = fetch_and_zero(&overlay->old_vma);
 	if (drm_WARN_ON(&overlay->i915->drm, !vma))
 		return;
 
-	intel_frontbuffer_flip_complete(overlay->i915,
-					INTEL_FRONTBUFFER_OVERLAY(overlay->crtc->pipe));
+	frontbuffer_flush(i915, INTEL_FRONTBUFFER_OVERLAY(pipe), ORIGIN_FLIP);
 
 	i915_vma_unpin(vma);
 	i915_vma_put(vma);
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list