[PATCH v1 1/2] Revert "drm/i915/display: ignore long HPDs based on a flag"

Vinod Govindapillai vinod.govindapillai at intel.com
Wed Mar 29 08:51:40 UTC 2023


This reverts commit b0fbef65e227ad4ea81bf2ad3d17d073bd0c68de.
---
 drivers/gpu/drm/i915/display/intel_display_core.h | 11 -----------
 drivers/gpu/drm/i915/display/intel_hotplug.c      |  9 ---------
 2 files changed, 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
index 0b5509f268a7..cc5c9382c24e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_core.h
+++ b/drivers/gpu/drm/i915/display/intel_display_core.h
@@ -183,17 +183,6 @@ struct intel_hotplug {
 	 * blocked behind the non-DP one.
 	 */
 	struct workqueue_struct *dp_wq;
-
-	/*
-	 * Flag to track if long HPDs need not to be processed
-	 *
-	 * Some panels generate long HPDs while keep connected to the port.
-	 * This can cause issues with CI tests results. In CI systems we
-	 * don't expect to disconnect the panels and could ignore the long
-	 * HPDs generated from the faulty panels. This flag can be used as
-	 * cue to ignore the long HPDs and can be set / unset using debugfs.
-	 */
-	bool ignore_long_hpd;
 };
 
 struct intel_vbt_data {
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index b12900446828..907ab7526cb4 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -389,13 +389,6 @@ static void i915_hotplug_work_func(struct work_struct *work)
 
 	spin_unlock_irq(&dev_priv->irq_lock);
 
-	/* Skip calling encode hotplug handlers if ignore long HPD set*/
-	if (dev_priv->display.hotplug.ignore_long_hpd) {
-		drm_dbg_kms(&dev_priv->drm, "Ignore HPD flag on - skip encoder hotplug handlers\n");
-		mutex_unlock(&dev_priv->drm.mode_config.mutex);
-		return;
-	}
-
 	drm_connector_list_iter_begin(&dev_priv->drm, &conn_iter);
 	for_each_intel_connector_iter(connector, &conn_iter) {
 		enum hpd_pin pin;
@@ -947,6 +940,4 @@ void intel_hpd_debugfs_register(struct drm_i915_private *i915)
 			    i915, &i915_hpd_storm_ctl_fops);
 	debugfs_create_file("i915_hpd_short_storm_ctl", 0644, minor->debugfs_root,
 			    i915, &i915_hpd_short_storm_ctl_fops);
-	debugfs_create_bool("i915_ignore_long_hpd", 0644, minor->debugfs_root,
-			    &i915->display.hotplug.ignore_long_hpd);
 }
-- 
2.34.1



More information about the Intel-gfx-trybot mailing list