[PATCH i-g-t] tests/kms_histogram: Remove eDP check in GHE tests
Naladala Ramanaidu
ramanaidu.naladala at intel.com
Tue Aug 27 13:36:17 UTC 2024
From: Mohammed Thasleem <mohammed.thasleem at intel.com>
Remove unnecessary connector checks to streamline the loop over
connected outputs. Add debug information in
run_tests_for_global_histogram to log messages when certain
conditions are met.
Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
---
tests/kms_histogram.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/kms_histogram.c b/tests/kms_histogram.c
index 066be8c6e..01a80d06e 100644
--- a/tests/kms_histogram.c
+++ b/tests/kms_histogram.c
@@ -163,7 +163,7 @@ static struct globalhist_args *algo_get_pixel_factor(drmModePropertyBlobRes *glo
argsPtr->resolution_y = mode->vdisplay;
igt_debug("Making call to global histogram algorithm.\n");
- set_histogram_data_bin(argsPtr);
+ ghe_set_histogram_data_bin(argsPtr);
return argsPtr;
}
@@ -280,23 +280,23 @@ static void run_tests_for_global_histogram(data_t *data, bool color_fb,
test_t test_pixel_factor)
{
enum pipe pipe;
- drmModeConnectorPtr connector;
igt_output_t *output;
for_each_connected_output(&data->display, output) {
- connector = output->config.connector;
- if (connector->connector_type != DRM_MODE_CONNECTOR_eDP)
- continue;
for_each_pipe(&data->display, pipe) {
- if (!igt_pipe_obj_has_prop(&data->display.pipes[pipe], IGT_CRTC_HISTOGRAM))
+ if (!igt_pipe_obj_has_prop(&data->display.pipes[pipe], IGT_CRTC_HISTOGRAM)) {
+ igt_info("igt_pipe_has_prop\n");
continue;
+ }
igt_display_reset(&data->display);
igt_output_set_pipe(output, pipe);
- if (!intel_pipe_output_combo_valid(&data->display))
+ if (!intel_pipe_output_combo_valid(&data->display)) {
+ igt_info("intel_pipe_combo_valid");
continue;
+ }
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output))
run_global_histogram_pipeline(data, pipe, output, color_fb, test_pixel_factor);
--
2.34.1
More information about the Intel-gfx-trybot
mailing list