[RFC v3 14/15] drm/i915/ddi: handle 128b/132b SST in intel_ddi_read_func_ctl()

[Imre Deak]

On Thu, Dec 19, 2024 at 02:47:36PM +0200, Jani Nikula wrote:
> On Wed, 18 Dec 2024, Imre Deak <imre.deak at intel.com> wrote:
> > From: Jani Nikula <jani.nikula at intel.com>
> [...]
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> > index 8b1977cfec503..7304220736b47 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> > @@ -760,8 +760,11 @@ static void intel_dp_update_link_bw_set(struct intel_dp *intel_dp,
> >  					const struct intel_crtc_state *crtc_state,
> >  					u8 link_bw, u8 rate_select)
> >  {
> > +	bool enhanced_framing = crtc_state->enhanced_framing ||
> > +				intel_dp_is_uhbr(crtc_state);
> > +
> 
> I think this is wrong. Enhanced framing is don't care for 128b/132b.

Right, confirmed, it shouldn't be set explicitly either in HW or in
DPCD. So not setting crtc_state->enhanced_framing for UHBR/SST is
enough and the above change must be dropped.

> 
> BR,
> Jani.
> 
> >  	intel_dp_link_training_set_bw(intel_dp, link_bw, rate_select, crtc_state->lane_count,
> > -				      crtc_state->enhanced_framing);
> > +				      enhanced_framing);
> >  }
> >  
> >  /*
> 
> -- 
> Jani Nikula, Intel