[PATCH 00/61] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y
Jim Cromie
jim.cromie at gmail.com
Wed Oct 16 18:12:43 UTC 2024
this rev: dd-fix-9q
mostly fiddling with macros to try to fix multi-expand warnings.
some commit-msg tweaking.
previous revision: dd-fix-9p (reused)
primarily attempts to quiet the DRM:CHECK warnings on macros, by
adding () around macro params where legal (it prevents ## pasting, or
it looks like a fn defn). scripts/checkpatch doesn't issue these
warnings, so I'm kinda guessing for a fix.
also squashed in a few commits, advanced others (simplify).
previous send:
init reserved_ids=0 before using it. hopefully it fixes this: (it did)
<3>[ 41.373660] dyndbg: [0..9] on DRM_UT_CORE conflicts with cf6738729c010300
<3>[ 41.373778] dyndbg: conflicting dyndbg-classmap reservations
previous send:
1. Clean up ddebug_attach_*module_classes(),
2. fix previous 3,4.
should fix the CI.BAT failure I found on -9m
Previous revision: dd-fix-9m
1- drop class "protection" special case, per Jason's preference.
current use is marked BROKEN so nobody to affect.
2- compile-time arg-tests in DYNDBG_CLASSMAP_DEFINE
implement required constraints, fail obviously.
3- modprobe time check of conflicting class-id reservations
only affects 2+classmaps users.
compile-time solution not apparent.
4- dyndbg can now cause modprobe to fail.
needed to catch 3.
Jim Cromie (61):
docs/dyndbg: update examples \012 to \n
test-dyndbg: fixup CLASSMAP usage error
dyndbg: reword "class unknown," to "class:_UNKNOWN_"
dyndbg: make ddebug_class_param union members same size
dyndbg: replace classmap list with a vector
dyndbg: ddebug_apply_class_bitmap - add module arg, select on it
dyndbg: split param_set_dyndbg_classes to _module & wrapper fns
dyndbg: drop NUM_TYPE_ARRAY
dyndbg: reduce verbose/debug clutter
dyndbg: silence debugs with no-change updates
dyndbg: tighten ddebug_class_name() 1st arg type
dyndbg: tighten fn-sig of ddebug_apply_class_bitmap
dyndbg: reduce verbose=3 messages in ddebug_add_module
dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
checkpatch: add an exception to the do-while wrapper advice
dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP
dyndbg: add/use for_subvec() to reduce boilerplate
dyndbg-test: change do_prints testpoint to accept a loopct
selftests-dyndbg: add tools/testing/selftests/dynamic_debug/*
dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API
dyndbg-doc: add classmap info to howto
docs-dyndbg: improve howto classmaps api section
dyndbg: treat comma as a token separator
selftests-dyndbg: add comma_terminator_tests
dyndbg: split multi-query strings with %
selftests-dyndbg: test_percent_splitting
docs/dyndbg: explain new delimiters: comma, percent
selftests-dyndbg: add test_mod_submod
dyndbg-doc: explain flags parse 1st
dyndbg: change __dynamic_func_call_cls* macros into expressions
dyndbg: drop "protection" of class'd pr_debugs from legacy queries
dyndbg: drop premature optimization in ddebug_add_module
dyndbg: check DYNDBG_CLASSMAP_DEFINE args at compile-time
dyndbg: allow ddebug_add_module to fail
dyndbg: fail modprobe if classmaps have conflicting class-id ranges
dyndbg: refactor ddebug_attach_*module_classes
drm: use correct ccflags-y spelling
checkpatch: dont warn about unused macro arg on empty body
drm-dyndbg: adapt drm core to use dyndbg classmaps-v2
drm-dyndbg: adapt DRM to invoke DYNDBG_CLASSMAP_PARAM
drm-print: fix config-dependent unused variable
drm-dyndbg: DRM_CLASSMAP_USE in amdgpu driver
drm-dyndbg: DRM_CLASSMAP_USE in i915 driver
drm-dyndbg: DRM_CLASSMAP_USE in drm_crtc_helper
drm-dyndbg: DRM_CLASSMAP_USE in drm_dp_helper
drm-dyndbg: DRM_CLASSMAP_USE in nouveau
drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver
drm-dyndbg: add DRM_CLASSMAP_USE to virtio_gpu
drm-dyndbg: add DRM_CLASSMAP_USE to simpledrm
drm-dyndbg: add DRM_CLASSMAP_USE to bochs
drm-dyndbg: add DRM_CLASSMAP_USE to etnaviv
drm-dyndbg: add DRM_CLASSMAP_USE to gma500 driver
drm-dyndbg: add DRM_CLASSMAP_USE to radeon
drm-dyndbg: add DRM_CLASSMAP_USE to vmwgfx driver
drm-dyndbg: add DRM_CLASSMAP_USE to vkms driver
drm-dyndbg: add DRM_CLASSMAP_USE to udl driver
drm-dyndbg: add DRM_CLASSMAP_USE to mgag200 driver
drm-dyndbg: add DRM_CLASSMAP_USE to the gud driver
drm-dyndbg: add DRM_CLASSMAP_USE to the qxl driver
drm-dyndbg: add DRM_CLASSMAP_USE to the drm_gem_shmem_helper driver
drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN
.../admin-guide/dynamic-debug-howto.rst | 115 +++-
MAINTAINERS | 3 +-
drivers/gpu/drm/Kconfig | 3 +-
drivers/gpu/drm/Makefile | 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 +-
drivers/gpu/drm/display/drm_dp_helper.c | 12 +-
drivers/gpu/drm/drm_crtc_helper.c | 12 +-
drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +
drivers/gpu/drm/drm_print.c | 38 +-
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +
drivers/gpu/drm/gma500/psb_drv.c | 2 +
drivers/gpu/drm/gud/gud_drv.c | 2 +
drivers/gpu/drm/i915/i915_params.c | 12 +-
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +
drivers/gpu/drm/nouveau/nouveau_drm.c | 12 +-
drivers/gpu/drm/qxl/qxl_drv.c | 2 +
drivers/gpu/drm/radeon/radeon_drv.c | 2 +
drivers/gpu/drm/tiny/bochs.c | 2 +
drivers/gpu/drm/tiny/simpledrm.c | 2 +
drivers/gpu/drm/udl/udl_main.c | 2 +
drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +
drivers/gpu/drm/vkms/vkms_drv.c | 2 +
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +
drivers/gpu/drm/xe/xe_drm_client.c | 2 +
include/asm-generic/vmlinux.lds.h | 1 +
include/drm/drm_print.h | 12 +
include/linux/dynamic_debug.h | 171 ++++--
kernel/module/main.c | 3 +
lib/Kconfig.debug | 24 +-
lib/Makefile | 3 +
lib/dynamic_debug.c | 502 +++++++++++-------
lib/test_dynamic_debug.c | 190 ++++---
lib/test_dynamic_debug_submod.c | 17 +
scripts/checkpatch.pl | 3 +-
tools/testing/selftests/Makefile | 1 +
.../testing/selftests/dynamic_debug/Makefile | 9 +
tools/testing/selftests/dynamic_debug/config | 2 +
.../dynamic_debug/dyndbg_selftest.sh | 358 +++++++++++++
38 files changed, 1150 insertions(+), 396 deletions(-)
create mode 100644 lib/test_dynamic_debug_submod.c
create mode 100644 tools/testing/selftests/dynamic_debug/Makefile
create mode 100644 tools/testing/selftests/dynamic_debug/config
create mode 100755 tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
--
2.47.0
More information about the Intel-gfx-trybot
mailing list