[PATCH 00/13] Prepare to transition to VRR TG

Ankit Nautiyal ankit.k.nautiyal at intel.com
Sat Feb 1 09:31:29 UTC 2025


Refactor existing VRR to prepare for introducing fixed rr:
-Always compute the vrr state based on actual uapi.vrr_enable knob.
So when that knob is disabled we always compute vmin=flipline=vmax.
-Update intel_vrr_{enable,disable}() to just flip between the fixed and
variable timings in vmin/flipline/vmax.
-Always set vmin=crtc_vtotal instead of the using the current refresh rate based approach.
That way we never need to change anything to do with the guardband.
-Disable CMRR for now since it complicates the toggle between fixed and variable timings.

Ankit Nautiyal (13):
  drm/i915/vrr: Remove unwanted comment
  drm/i915:vrr: Separate out functions to compute vmin and vmax
  drm/i915/vrr: Make helpers for cmrr and vrr timings
  drm/i915/vrr: Simplify CMRR Enable Check in intel_vrr_get_config
  drm/i915/vrr: Introduce new field for VRR mode
  drm/i915/vrr: Fill VRR timing generator mode for CMRR and VRR
  drm/i915/display: Remove vrr.enable and instead check vrr.mode != NONE
  drm/i915/display: Absorb cmrr attributes into vrr struct
  drm/i915/display: Add vrr mode to crtc_state dump
  drm/i915/vrr: Disable CMRR
  drm/i915/display: Update intel_crtc_vrr_{enable/disable}
  drm/i915/vrr: Use crtc_vtotal for vmin
  drm/i915/vrr: Prepare for fixed refresh rate timings

 .../drm/i915/display/intel_crtc_state_dump.c  |  19 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |   3 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  47 ++--
 .../drm/i915/display/intel_display_types.h    |  16 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |   4 +-
 drivers/gpu/drm/i915/display/intel_dsb.c      |   2 +-
 .../drm/i915/display/intel_modeset_setup.c    |   3 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   5 +-
 drivers/gpu/drm/i915/display/intel_vrr.c      | 200 +++++++++++++-----
 drivers/gpu/drm/i915/display/intel_vrr.h      |   1 +
 drivers/gpu/drm/i915/display/skl_watermark.c  |   3 +-
 11 files changed, 210 insertions(+), 93 deletions(-)

-- 
2.45.2



More information about the Intel-gfx-trybot mailing list