[Intel-gfx] [PATCH] Use enable bit for LVDS detect

Jesse Barnes jbarnes at virtuousgeek.org
Mon Dec 1 20:38:53 CET 2008


On Tuesday, November 25, 2008 10:30 pm Wang, Zhenyu Z wrote:
> On 2008.11.26 09:06:26 +0800, Wang, Zhenyu Z wrote:
> > > So you just find the first non-special directory entry in the lid dir? 
> > > Is one always guaranteed to exist?
> >
> > If 'lid' dir exists under 'button' dir, that means there's a LID device
> > found, and acpi button will create a subdir. And above code has also
> > checked if no LID device was found.
> >
> > And there's another lid state say 'unsupported' have to be guarded too,
> > only 'open' or 'closed' tells the real state.
>
> Here's updated patch, which take care of 'unsupported' state and use SWF
> definition from i830_bios.h.
>
> From 17aebdfffb5e233f400065e3ad3234e89f72c463 Mon Sep 17 00:00:00 2001
> From: Zhenyu Wang <zhenyu.z.wang at intel.com>
> Date: Wed, 26 Nov 2008 14:26:18 +0800
> Subject: [PATCH] Try to add LVDS detect support
>
> This one trys to use lid status for LVDS detect,
> which works when internal panel is not used as primary
> display alone, or there's no internal panel at all.
> ACPI button driver's lid state interface is preferred,
> and SWF state is also checked if ACPI method failed.

Yeah, looks nice.  Maybe this will obsolete some of our quirks.

Jesse



More information about the Intel-gfx mailing list