[Intel-gfx] xf86-video-intel: src/xvmc/intel_xvmc.c

Zou, Nanhai nanhai.zou at intel.com
Thu Dec 18 10:26:55 CET 2008


>-----Original Message-----
>From: Wang, Zhenyu Z
>Sent: 2008年12月18日 16:42
>To: Zou, Nanhai
>Cc: intel-gfx
>Subject: Re: xf86-video-intel: src/xvmc/intel_xvmc.c
>
>On 2008.12.18 16:26:01 +0800, Zou, Nanhai wrote:
>> >
>> >This is broken as no care is taken for vblank pipes (e.g I have to
>> >add DRM_VBLANK_SECONDARY for my GM965 LVDS on pipe B).
>> >As XvMC uses Xv port for video playback, we should just fix
>> >Xv port for vblank sync. My suggest is to add a Xv port attribute
>> >for texture video, that can flip vblank wait on or off. Or we
>> >might steal some idea from radeon driver. But doing this in XvMC
>> >lib is wrong to me anyway.
>> >
>> Wait in server context is not a good idea, either busy wait or sleep, user
>experience will not be good when server stall for vblank.
>> So let's do it in client context.
>
>yeah, that's good, but we need to fix second pipe vblank case.
>

Ok, please test the attached patch for me, since I don't have a machine connect with 2 planes by hand to test.

Thanks
Zou Nan hai

Detect xvmc render plane.
Signed-off-by: Zou Nan hai <Nanhai.zou at intel.com>

>--
>Open Source Technology Center, Intel ltd.
>
>$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vblank_plane.patch
Type: application/octet-stream
Size: 2647 bytes
Desc: vblank_plane.patch
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081218/c07abd2d/attachment.obj>


More information about the Intel-gfx mailing list