[Intel-gfx] [PATCH] i965: Support render acceleration with pixmaps in BOs.

Eric Anholt eric at anholt.net
Thu Nov 6 01:31:28 CET 2008


On Wed, 2008-11-05 at 15:51 -0800, Carl Worth wrote:
> On Wed, 2008-11-05 at 14:45 -0800, Eric Anholt wrote:
> > This required reordering the relocation emits for surface/binding table
> > so that we didn't add new relocations to things that had already been
> > relocated at (the check_aperture requirement).
> 
> Excellent, Eric! I love people doing stuff for me before I get a chance
> to. There's no way I'll complain about that! :-)
> 
> > +    if (pixmap_bo != NULL) {
> > +	dri_bo_emit_reloc(ss_bo, I915_GEM_DOMAIN_SAMPLER, 0,
> > +			  0,
> > +			  ss_index * sizeof(*ss) +
> > +			  offsetof(struct brw_surface_state, ss1),
> > +			  pixmap_bo);
> > +    }
> 
> Do we not need something non-zero for the write_domains argument in the
> case of our destination pixmap? Or are we one level above that here?

Nope, we definitely need (RENDER,RENDER) not (SAMPLER,0) in destination.
Thanks!

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081105/61fb79cb/attachment.sig>


More information about the Intel-gfx mailing list