[Intel-gfx] [PATCH] Make I830FALLBACK debugging a runtime instead of compile-time option.

[Eric Anholt]

On Thu, 2008-11-06 at 09:15 +0800, Zhenyu Wang wrote:
> On 2008.11.06 05:52:03 +0800, Eric Anholt wrote:
> > @@ -959,6 +961,15 @@ static inline int i830_fb_compression_supported(I830Ptr pI830)
> >      return TRUE;
> >  }
> >  
> > +#define I830FALLBACK(s, arg...)				\
> > +do {							\
> > +    if (I830PTR(pScrn)->fallback_debug) {		\
> > +	xf86DrvMsg(pScrn->scrnIndex, X_INFO,		\
> > +		   "EXA fallback: " s "\n", ##arg);	\
> > +	return FALSE;					\
> > +    }							\
> > +} while(0)
> > +
> >  Bool i830_pixmap_tiled(PixmapPtr p);
> >  
> >  #define i830_exa_check_pitch_2d(p) do {\
> 
> Does this mean if no fallback debug option was set, we won't really
> fallback (return FALSE;)?

Wow, thank you for catching that.  Fixed in the version pushed, as well
as cworth's comment about the manpage.  Thinking about the defaults
stuff in the manpage, could someone with manpage-fu tell me what we
should do for getting a bulleted-list sort of thing in the indented
section for the defaults, instead of having it inlined with the
paragraph?

       Option "TripleBuffer" "boolean"
              Enable support for triple buffering. This should improve 3D per‐
              formance  at  the potential cost of worse performance with mixed
              2D/3D. Also note that this gives no benefit without  correspond‐
              ing  support  in the Mesa 3D driver and may not give any benefit
              without page flipping either (see Option "PageFlip" ).   Default
              for  i810:  The option is not used.  Default for i830 and above:
              Disabled.


-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081105/768d714b/attachment.sig>