[Intel-gfx] [PATCH] [drm] Move drm vblank initialization/cleanup to driver load/unload

Jesse Barnes jbarnes at virtuousgeek.org
Tue Nov 18 22:00:24 CET 2008


On Tuesday, November 18, 2008 12:17 pm Jesse Barnes wrote:
> On Tuesday, November 18, 2008 9:48 am Keith Packard wrote:
> > This should fix the compiz issues across vt switch (works for me).
> >
> > From 087e40e095de737d948f26bb1c28bba34a274fdb Mon Sep 17 00:00:00 2001
> > From: Keith Packard <keithp at keithp.com>
> > Date: Tue, 18 Nov 2008 09:30:25 -0800
> > Subject: [PATCH] [drm] Move drm vblank initialization/cleanup to driver
> > load/unload
> >
> > drm vblank initialization keeps track of the changes in driver-supplied
> > frame counts across vt switch and mode setting, but only if you let it by
> > not tearing down the drm vblank structure.
> >
> > Signed-off-by: Keith Packard <keithp at keithp.com>
>
> Acked-by: Jesse Barnes <jesse.barnes at intel.com>
>
> This looks correct (in fact we used to do it this way but somehow it made
> it upstream in a different form; I know because this was explicitly tested
> last time we did validation).  It'll also fix the suspend/resume case.

Just remembered that other drivers will need updates here too, otherwise they 
may leak memory due to multiple drm_vblank_init calls on every IRQ 
postinstall.

Jesse



More information about the Intel-gfx mailing list