[Intel-gfx] [PATCH] Use enable bit for LVDS detect
Jesse Barnes
jbarnes at virtuousgeek.org
Sat Nov 22 02:15:28 CET 2008
On Friday, November 21, 2008 11:00 am Keith Packard wrote:
> On Fri, 2008-11-21 at 10:08 -0800, Jesse Barnes wrote:
> > if ((I915_READ(LVDS) & LVDS_EN) && i830_lvds_lid_open(pI830))
> > return TRUE;
> > return FALSE;
>
> I'd say we should use the lid detect but not test whether the LVDS is
> currently on.
Yeah right after I sent the message I realized that using LVDS_EN would
prevent a present LVDS from ever being listed as "connected", which would be
bad. We could return OutputStatusUnknown in that case, but I wonder if just
checking lid status would work on the Eee box and other mobile chip/desktop
system type platforms.
--
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list