[Intel-gfx] [PATCH] [drm] Move drm vblank initialization/cleanup to driver load/unload

Jesse Barnes jbarnes at virtuousgeek.org
Mon Nov 24 20:18:32 CET 2008


On Tuesday, November 18, 2008 5:27 pm Keith Packard wrote:
> On Tue, 2008-11-18 at 13:00 -0800, Jesse Barnes wrote:
> > Just remembered that other drivers will need updates here too, otherwise
> > they may leak memory due to multiple drm_vblank_init calls on every IRQ
> > postinstall.
>
> Here's an untested patch that fixes the other drivers in the same way:
>
> From 8d592c0c7ec8d8ee4fb32477b7e7f89c74d09ccc Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp at keithp.com>
> Date: Tue, 18 Nov 2008 09:30:25 -0800
> Subject: [PATCH] [drm] Move drm vblank initialization/cleanup to driver
> load/unload
>
> drm vblank initialization keeps track of the changes in driver-supplied
> frame counts across vt switch and mode setting, but only if you let it by
> not tearing down the drm vblank structure.

Looks good; we should get this upstream asap since several people running 
compiz are hitting this problem.

Dave?

Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center




More information about the Intel-gfx mailing list