[Intel-gfx] [PATCH] [drm/i915] Always read pipestat in irq_handler

Keith Packard keithp at keithp.com
Fri Nov 28 19:24:56 CET 2008


On Fri, 2008-11-28 at 17:13 +0800, Li Peng wrote:
>  
>  	iir = I915_READ(IIR);
>  
> +	if (iir == 0)
> +		return IRQ_NONE;
> +

We can't do that -- iir may be zero while there are still pipe
interrupts pending, due to the ordering between pipe stat writes and iir
writes. However, it looks like we need to ensure that the pipe stat
values are set before enabling interrupts.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081128/5cd1e7e9/attachment.sig>


More information about the Intel-gfx mailing list