[Intel-gfx] [PATCH] Use pipes, not planes for sarea geometry data

[Eric Anholt]

On Sat, 2008-10-18 at 19:39 -0700, Keith Packard wrote:
> Vblank in the kernel is far simpler if it deals with pipes instead of
> planes, so we're changing both user and kernel side. This is the user mode
> side.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  src/i830_display.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/i830_display.c b/src/i830_display.c
> index 0632f3a..661261a 100644
> --- a/src/i830_display.c
> +++ b/src/i830_display.c
> @@ -756,7 +756,7 @@ static void i830_modeset_ctl(xf86CrtcPtr crtc, int pre)
>      if (!pI830->directRenderingEnabled)
>        return;
>  
> -    modeset.crtc = intel_crtc->plane;
> +    modeset.crtc = intel_crtc->pipe;
>  
>      /*
>       * DPMS will be called many times (especially off), but we only
> @@ -921,7 +921,7 @@ i830_crtc_dpms(xf86CrtcPtr crtc, int mode)
>  	if (!sPriv)
>  	    return;
>  
> -	switch (plane) {
> +	switch (pipe) {
>  	case 0:
>  	    sPriv->planeA_w = enabled ? crtc->mode.HDisplay : 0;
>  	    sPriv->planeA_h = enabled ? crtc->mode.VDisplay : 0;

Looks like you missed the same code in i830PipeSetBase.  It should
probably be a function, and the sarea member renamed to pipe[AB]_[wh]
(mesa has its own copy of the sarea definition, so no cross-module API
compatibiltiy to worry about).  There's some interaction in
i830_dri.c:I830DRIClipNotify() as well that should be examined.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081018/75c97361/attachment.sig>