[Intel-gfx] [PATCH] EXA pixmap management support (for GTT mapping)

[Eric Anholt]

On Wed, 2008-10-22 at 15:22 -0700, Jesse Barnes wrote:
> On Wednesday, October 22, 2008 3:18 pm Jesse Barnes wrote:
> > On Wednesday, October 22, 2008 3:07 pm Jesse Barnes wrote:
> > > This is a rough patch I've been testing the GTT mapping support with.  It
> > > basically converts the i830 EXA code to doing its own pixmap management,
> > > and makes the driver assume that the kernel will take care of setting up
> > > fence registers for GTT mapped objects (pinned objects included).
> > >
> > > Something in the conversion broke render accel, but I haven't found what
> > > yet; could definitely be kernel related given the list management trouble
> > > I've got in the GTT mapping patch.
> > >
> > > Anyway I'm open to suggestions on this patch, how to clean it up, etc.  I
> > > think it's about time to remove XAA support now...
> >
> > Ugg, w/o word wrapping this time.
> 
> Sigh.  Make it build too (that'll teach me to add a few cleanups w/o building
> before sending out).

A couple notes:

EXA minor 1.4 means that we require server 1.5 it looks like.  I'm not
sure if we're ready for that.

It looks like you won't break XAA+rotation, for what it's worth.  If we
can avoid the server 1.5 requirement for EXA, I'd really like to see us
drop XAA at this point.  It's not like it really works on newer
hardware, anyway.  And if we could unifdef EXA, I'd be even happier --
it really makes a mess of a bunch of our code.

It'll certainly break 965 render accel since it's not using
OUT_RELOC_PIXMAP.  cworth's working on getting that ready, but I don't
want to see this patch land until then.

In non-GEM, BO-pixmaps mode, i830_memory.c needs to stop allocating the
EXA offscreen space and allocate that as pixmap space instead (if you
scaled the size down a bit at the same time, I definitely wouldn't
complain -- it should probably be a function of aperture size rather
than screen virtual).

Other than that this seems like good stuff, and I'm glad you wrote it.
Being able to compare EXA and UXA will be very useful.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081027/ee8d535b/attachment.sig>