[Intel-gfx] [PATCH] Eliminate INT10 call to get BIOS contents

Keith Packard keithp at keithp.com
Tue Sep 30 19:09:17 CEST 2008


On Tue, 2008-09-30 at 11:11 +0200, Julien Cristau wrote:

> So you remove the allocation of this buffer...

Yeah, oops. Second patch fixes that :-)

> Btw, it would seem pci_device_read_rom really wants to take a size
> parameter, to make sure it doesn't write past the end of its buffer.

Actually, it writes pDev->rom_size bytes, so we just need to allocate
that much.

Check out the second patch I sent; I'm hoping that's in better shape.

Thanks much for reviewing the patch though!

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20080930/a77bba28/attachment.sig>


More information about the Intel-gfx mailing list