[Intel-gfx] [PATCH 2/2] Fix up some pI830->memory_manager versus use_drm_mode confusion.

Eric Anholt eric at anholt.net
Wed Apr 22 21:48:24 CEST 2009


On Wed, 2009-04-22 at 08:46 -0700, Jesse Barnes wrote:
> On Tue, 21 Apr 2009 20:27:35 -0700
> Eric Anholt <eric at anholt.net> wrote:
> 
> > We'd end up doing direct drm_intel_bo_maps of our tiled buffers for sw
> > fallbacks, resulting in bad rendering with KMS.  Also cleans up a
> > spurious error message.x
> > ---
> >  src/i830_driver.c |    2 +-
> >  src/i830_exa.c    |    4 ++--
> >  src/i830_memory.c |    7 ++++---
> >  3 files changed, 7 insertions(+), 6 deletions(-)
> 
> Wow this really makes me wonder how things ever worked, nice catch.

Nope, this was what you mentioned on IRC, the broken warning fix.  We do
currently allocate "aperture space" (not really) for the memory manager,
it just has no effect except for filling in the pointer.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090422/31bbdcd8/attachment.sig>


More information about the Intel-gfx mailing list