[Intel-gfx] xf86-video-intel: Commit 08ebde4715b87867184d42b60762cd774e151f5c breaks kernel memory manager allocation
fengguang.wu at intel.com
Thu Apr 30 13:36:27 CEST 2009
On Thu, Apr 30, 2009 at 07:30:25PM +0800, Magnus Kessler wrote:
> On Thursday 30 Apr 2009 12:10:46 Wu Fengguang wrote:
> > On Thu, Apr 30, 2009 at 06:52:52PM +0800, Magnus Kessler wrote:
> > > On Thursday 30 Apr 2009 11:36:37 Wu Fengguang wrote:
> > > > On Thu, Apr 30, 2009 at 06:09:03PM +0800, Magnus Kessler wrote:
> > > > > A cosmetic problem exists in the output of the memory allocation in
> > > > > the xorg.log:
> > > > >
> > > > > (II) intel(0): Fixed memory allocation layout:
> > > > > (II) intel(0): 0x00000000-0x7fffffffffffffff: DRI memory manager
> > > > > (9007199254740992 kB)
> > > > > (II) intel(0): 0x00000000: end of aperture
> > > > >
> > > > > That huge value might just raise some eyebrows.
> > > >
> > > > Or reduce to 48bit?
> > > > size = ALIGN(ULONG_MAX >> 16, GTT_PAGE_SIZE);
> > >
> > > That's still a ridiculously large value today. I actually liked the
> > > previous behaviour (ULONG_MAX), which printed as 0 from
> > > i830_describe_allocations(), and worked just fine for me.
> > Yes that working but tricky (size = ULONG_MAX) - it damaged a dozen little
> > poor brain cells I suspect.
> > > Would it make sense to add a special case to i830_describe_allocations()
> > > to deal with the DRI case?
> > We can do that - but on the other side, isn't this a fine strong
> > indication of "ALL memory are managed by DRI memory manager"? ;-)
> Exactly what I meant. Print out a message to that effect, and not bother about
> the exact humongous value being used internally in the output.
I'm OK with a more user friendly message then 8-)
More information about the Intel-gfx