[Intel-gfx] [Patch] drm/i915: Set the multiplier for SDVO on G33 platform

ykzhao yakui.zhao at intel.com
Thu Aug 13 03:43:08 CEST 2009


On Fri, 2009-08-07 at 18:12 +0800, Zhenyu Wang wrote:
> On 2009.08.06 17:36:40 +0800, yakui.zhao at intel.com wrote:
> > From: Sean Young <sean at mess.org>
> > 
> > Set the multiplier correctly for SDVO on G33 platform
> > 
> > http://bugs.freedesktop.org/show_bug.cgi?id=21417
> > 
> > Signed-off-by: Sean Young <sean at mess.org>
> > reviewed-by: Zhao Yakui <yakui.zhao at intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Index: linux-2.6/drivers/gpu/drm/i915/intel_display.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/gpu/drm/i915/intel_display.c	2009-08-06 17:27:25.000000000 +0800
> > +++ linux-2.6/drivers/gpu/drm/i915/intel_display.c	2009-08-06 17:30:15.000000000 +0800
> > @@ -2396,7 +2396,7 @@
> >  		if (is_sdvo) {
> >  			dpll |= DPLL_DVO_HIGH_SPEED;
> >  			sdvo_pixel_multiply = adjusted_mode->clock / mode->clock;
> > -			if (IS_I945G(dev) || IS_I945GM(dev))
> > +			if (IS_I945G(dev) || IS_I945GM(dev) || IS_G33(dev))
> >  				dpll |= (sdvo_pixel_multiply - 1) << SDVO_MULTIPLIER_SHIFT_HIRES;
> >  			else if (IS_IGDNG(dev))
> >  				dpll |= (sdvo_pixel_multiply - 1) << PLL_REF_SDVO_HDMI_MULTIPLIER_SHIFT;
> 
> Seems a missing sync from ums to kms. Thanks!
Right.

Hi, Eric
   Will you please pick up this patch?
   Otherwise the SDVO can't work well on G33 platform with KMS enabled.
   
thanks.
> 
> Acked-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> 




More information about the Intel-gfx mailing list