[Intel-gfx] [PATCH] Also write to bl_power when setting brightness.

[Matthew Garrett]

On Tue, Aug 18, 2009 at 07:07:23PM +0200, Matthias Hopf wrote:
> +    len = snprintf(val, BACKLIGHT_VALUE_LEN, "%d\n",
> +		   level > 0 ? FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN);

Doesn't this make it impossible to use the minimum value? I don't think 
that's a good tradeoff. The alternative (bumping everything up by one 
and adding an extra 0 level to turn the backlight off) means that 
there'll be two equivalent levels on hardware where the power attribute 
doesn't work. I think you're better off not doing this, and just leaving 
backlight enable/disable up to DPMS.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org