[Intel-gfx] [PATCH] drm/i915: Add 30ms delay in course of SDVO-TV detection

Eric Anholt eric at anholt.net
Tue Dec 1 19:42:13 CET 2009


On Fri,  6 Nov 2009 15:39:56 +0800, yakui.zhao at intel.com wrote:
> From: Zhao Yakui <yakui.zhao at intel.com>
> 
> Add 30ms delay in course of SDVO-TV detection. Otherwise sometimes the SDVO-TV
> can't be detected correctly although it is connected.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=24290
> https://bugs.freedesktop.org/show_bug.cgi?id=20785
> 
> Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> Tested-by: Yan Seiner <yan at seiner.com>

Applied.  You've got a funny convention in your commit messages, though,
where you copy the first line of the commit message into the second
paragraph.  I end up deleting that most of the time when I notice it.
The second paragraph should be additional details to the summary for
understanding the change.  Here's what I ended up putting on
this patch:

drm/i915: Add 30ms delay to make SDVO TV detection reliable.

Without this, on some boots the TV wouldn't be detected.  Testing
showed 15ms to be insufficient.

https://bugs.freedesktop.org/show_bug.cgi?id=24290
https://bugs.freedesktop.org/show_bug.cgi?id=20785

Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
Tested-by: Yan Seiner <yan at seiner.com>
Signed-off-by: Eric Anholt <eric at anholt.net>



More information about the Intel-gfx mailing list