[Intel-gfx] [PATCH] drm/i915: Promote invalid buffer alignment.

[Chris Wilson]

On Sat, 5 Dec 2009 23:57:07 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> I'm really uncomfortable with this suggestion.  For one, BUG_ON causes a 
> kernel panic, killing the whole system.  This seems rather extreme...even 
> with completely dead graphics, it's useful to keep the system alive so one 
> can at least ssh in and shut down cleanly.

The suggestion was to move the EINVAL checking to the kernel-userspace
boundary in the ioctls, and then to BUG_ON if we ever saw an invalid
alignment -- which would indeed be a kernel programming error. BUG_ON
does not in itself cause a panic, and in the likely cases here you will
still be able to ssh in and inspect the system.
-ickle

-- 
Chris Wilson, Intel Open Source Technology Centre