[Intel-gfx] [PATCH] drm/i915: Don't clflush purged objects on unbind

Eric Anholt eric at anholt.net
Wed Dec 9 08:50:26 CET 2009


On Tue,  8 Dec 2009 22:17:20 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> If the object is marked as purgeable and we are about to simply truncate
> those pages, don't waste time by clearing the cache lines for the
> object.  In typical usage this saves around 10% of the clflushes.

What I'm concerned about here is a dirtied object: you've now flushed
the GPU cachelines to main memory, but the CPU might be sitting on some
read cachelines (see the madness in the pread path for partial cpu read
domain stuff, though speculation might also cause this).

Could that get us into trouble somehow?  I'm not exactly sure.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091208/219904f9/attachment.sig>


More information about the Intel-gfx mailing list