[Intel-gfx] [PATCH] drm/i915: Check and update LVDS connector status after receiving LID notification event

Jesse Barnes jbarnes at virtuousgeek.org
Thu Dec 10 19:14:01 CET 2009


On Thu, 10 Dec 2009 08:46:55 +0800
ykzhao <yakui.zhao at intel.com> wrote:

> On Wed, 2009-12-02 at 10:54 +0800, Zhao, Yakui wrote:
> > From: Zhao Yakui <yakui.zhao at intel.com>
> 
> Hi, Eric
>     Any comment about this patch?
>     If we don't update the status of LVDS connector in time, maybe
> nothing is displayed on LVDS panel after close/reopen the LID.
> 
> Thanks.
> > 
> > Now the LID state is used to check whether the LVDS is connected or
> > disconnected. And when the LID is closed, it means that the LVDS is
> > disconnected. When it is reopened, it means that the LVDS is
> > connected.
> > 
> > At the same time on some distributions the LID event is also used
> > to put the system into suspend state. When the LID is closed, the
> > system will enter the suspend state. When the LID is reopened, the
> > system will be resumed.
> > 
> > In such case when the LID is closed, the LVDS is detected as
> > disconnected and then the system will enter the suspended state.
> > When the LID is reopened, the system will be resumed. But as the
> > LVDS status is not updated in course of resume, it will cause that
> > the LVDS connector is marked as unused and disabled. Even when we
> > try to configure the display mode for LVDS, it still can't work if
> > we don't update the status of LVDS connector.
> > 
> > check and update the status of LVDS connector after receiving the
> > LID notication event. Then after the system is resumed from
> > suspended state, we can set the display mode for LVDS correctly.

Yeah, looks like something we need to properly handle the resume & lid
open case if X isn't reprobing outputs.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list