[Intel-gfx] [PATCH] drm/i915: Set framebuffer alignment based upon the fence constraints.
chris at chris-wilson.co.uk
Wed Feb 11 15:26:30 CET 2009
Set the request alignment to 0, and leave it up to i915_gem_object_pin()
to set the appropriate alignment to match the fence covering the object.
Eric Anholt mentioned that the pinning code is meant to choose the
maximum of the request alignment and that of the fence covering the
object... However currently, the pinning code will only apply the fence
constraints if the supplied alignment is 0.
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
drivers/gpu/drm/i915/intel_display.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 53ce69c..b7c0ee0 100644
@@ -387,10 +387,8 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
alignment = 64 * 1024;
- if (IS_I9XX(dev))
- alignment = 1024 * 1024;
- alignment = 512 * 1024;
+ /* pin() will align the object as required by fence */
+ alignment = 0;
/* FIXME: Is this true? */
More information about the Intel-gfx