[Intel-gfx] [PATCH] Don't touch the pipestat regs for detecting FIFO underrun. The kernel owns them.

[Eric Anholt]

On Mon, 2008-12-29 at 14:07 -0800, Jesse Barnes wrote:
> On Monday, December 29, 2008 1:45 pm Eric Anholt wrote:
> > Since we don't perform any synchronization with the kernel on these regs,
> > we could race with the kernel to write stale values and end up not having
> > vblank interrupts enabled when somebody was waiting on one.
> > ---
> >  src/i830_display.c |    4 ----
> >  src/i830_driver.c  |   26 --------------------------
> >  2 files changed, 0 insertions(+), 30 deletions(-)
> >

> If we do this (patch seems fine) we should check for it in the kernel instead, 
> maybe by enabling the corresponding error interrupt.

There's preliminary stuff for it in the error-recovery branch of my
tree, but it got backed out because it caused hangs that killed ssh and
I didn't have time to debug.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090102/36538cf7/attachment.sig>