[Intel-gfx] [PATCH] allocate MCHBAR space & enable if necessary

[Chris Wilson]

On Tue, 2009-01-27 at 15:27 -0800, Jesse Barnes wrote:
> I noticed on my Eee 901 that the i915 DRM driver wasn't reading the MCHBAR reg
> at startup time, and so it would disable tiling.  For decent performance,
> especially on an Eee-like platform, tiling is a must.  So I put this patch
> together to allocate MCHBAR space and enable it if necessary.  I've only
> tested it on 915 so far, but would appreciate wider testing.

Here's a success story, of sorts! I eagerly applied this patch and tried
to use I915_TILING_Y on my Eee 700, only to hit the failure paths in
i915_gem_set_tiling() and leak the object references. But I did observe
a performance increase from using TILING_X for the scan out buffer.

The trivial patch attached frees the object references on the error
paths. Thanks!
-ickle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-i915-Unref-the-object-after-failing-to-set-tili.patch
Type: text/x-patch
Size: 1325 bytes
Desc: 
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090130/c0dec134/attachment.bin>