[Intel-gfx] [PATCH] drm/i915: only use CRT_HOTPLUG_FORCE_DETECT on 965+

[Jesse Barnes]

On Wed, 01 Jul 2009 11:29:16 -0700
Eric Anholt <eric at anholt.net> wrote:

> On Mon, 2009-06-22 at 13:03 -0700, Jesse Barnes wrote:
> > VGA detection on 945 and below shouldn't try to use
> > CRT_HOTPLUG_FORCE_DETECT.  It's not documented and leads to flaky
> > VGA detection on my AspireOne.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_crt.c
> > b/drivers/gpu/drm/i915/intel_crt.c index 6de97fc..c41cb00 100644
> > --- a/drivers/gpu/drm/i915/intel_crt.c
> > +++ b/drivers/gpu/drm/i915/intel_crt.c
> > @@ -390,7 +390,7 @@ static enum drm_connector_status
> > intel_crt_detect(struct drm_connector *connecto int dpms_mode;
> >  	enum drm_connector_status status;
> >  
> > -	if (IS_I9XX(dev) && !IS_I915G(dev) && !IS_I915GM(dev)) {
> > +	if (IS_I965G(dev)) {
> >  		if (intel_crt_detect_hotplug(connector))
> >  			return connector_status_connected;
> >  		else
> 
> It's documented in mine for 945G, 945GM, and G33.  Are we just doing
> hotplug detect wrong?

I think we must be, since it's been working for awhile.  I think Ma
Ling has been doing the most work in this area, maybe he has an idea of
how things might have broken?  I'll look through the logs and see if I
can come up with ideas too.

-- 
Jesse Barnes, Intel Open Source Technology Center