[Intel-gfx] [PATCH] drm/i915: Disable GEM when a broken video BIOS takes up the whole aperture.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eric Anholt wrote:

> @@ -1184,9 +1182,22 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
>  			 "performance may suffer.\n");
>  	}
>  
> +	ret = i915_probe_agp(dev, &agp_size, &prealloc_size);
> +	if (ret)
> +		goto out_iomapfree;
> +
>  	/* enable GEM by default */
>  	dev_priv->has_gem = 1;
>  
> +	if (prealloc_size > agp_size * 3 / 4) {
> +		DRM_ERROR("Detected broken video BIOS with %d/%dkB of video "
> +			  "memory stolen.\n",
> +			  prealloc_size / 1024, agp_size / 1024);
> +		DRM_ERROR("Disabling GEM. (try reducing stolen memory or "
> +			  "updating to fix).\n");

May be say "updating BIOS to fix"?  Other than that, looks good to me.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> +		dev_priv->has_gem = 0;
> +	}
> +
>  	dev->driver->get_vblank_counter = i915_get_vblank_counter;
>  	dev->max_vblank_count = 0xffffff; /* only 24 bits of frame count */
>  	if (IS_G4X(dev) || IS_IGDNG(dev)) {

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpM/XwACgkQX1gOwKyEAw+RkACZASPGp/kqQj+7DU/jwZ1yT7PI
lvUAn31KVUHYSZbjLKLHMsUFc7majhPd
=PmuU
-----END PGP SIGNATURE-----