[Intel-gfx] [PATCH 6/7] KMS: Keep screen pixmap devPrivate.ptr NULL during init and resize

[Eric Anholt]

On Fri, 2009-07-10 at 17:14 -0700, Keith Packard wrote:
> The frame buffer only has a valid address between prepare_access and
> finish_access calls, so remove all other attempts to compute an address from
> the driver.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  src/drmmode_display.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 7cfdc5b..df10fb5 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -1056,12 +1056,9 @@ drmmode_xf86crtc_resize (ScrnInfoPtr scrn, int width, int height)
>  		goto fail;
>  
>  	i830_set_pixmap_bo(screen->GetScreenPixmap(screen), pI830->front_buffer->bo);
> -	scrn->fbOffset = pI830->front_buffer->offset;
>  
>  	screen->ModifyPixmapHeader(screen->GetScreenPixmap(screen),
>  				   width, height, -1, -1, pitch * pI830->cpp, NULL);
> -	xf86DrvMsg(scrn->scrnIndex, X_INFO, "New front buffer at 0x%lx\n",
> -		   pI830->front_buffer->offset);
>  
>  	for (i = 0; i < xf86_config->num_crtc; i++) {
>  		xf86CrtcPtr crtc = xf86_config->crtc[i];

This one and #3 seem to be in disagreement.  Perhaps some squashing?

Other than that, it looks fine to me.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090710/1c335251/attachment.sig>